New Api definition #138
Open
New Api definition #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsSetStandbyVideoState dsGetStandbyVideoState dsSetAvPortState dsSetLEDStatus dsSetRebootConfig
karuppaiyak
reviewed
Sep 9, 2025
karuppaiyak
reviewed
Sep 9, 2025
karuppaiyak
reviewed
Sep 9, 2025
karuppaiyak
reviewed
Sep 9, 2025
skamath
reviewed
Sep 9, 2025
ds/videoOutputPort.cpp
Outdated
|
|
||
| bool VideoOutputPort::SetStandbyVideoState(const string port , const bool enable) | ||
| { | ||
| dsError_t ret = dsSetStandbyVideoState(port, enable); |
Contributor
There was a problem hiding this comment.
better to propagate dsError_t, applicable to other APIs too..
ds/hdmiIn.cpp
Outdated
| printf ("%s:%d - HDMI Compatibility Version = %d\n", __PRETTY_FUNCTION__, __LINE__, *capversion); | ||
| } | ||
|
|
||
| void HdmiInput::getHDMIARCPortId(int *portId) |
Contributor
There was a problem hiding this comment.
better to propagate dsError_t
karuppaiyak
reviewed
Sep 9, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds new API definitions for managing standby video state and HDMI ARC port functionality. The changes implement functions to get and set standby video states for video ports, along with a new function to retrieve HDMI ARC port IDs.
- Implements
dsSetStandbyVideoStateanddsGetStandbyVideoStatefunctions for managing video port standby states - Adds corresponding C++ wrapper methods in
VideoOutputPortclass - Introduces
getHDMIARCPortIdfunction inHdmiInputclass for retrieving ARC port information
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| rpc/cli/dsVideoPort.c | Implements core C functions for setting and getting standby video state |
| ds/videoOutputPort.cpp | Adds C++ wrapper methods for standby video state management |
| ds/include/videoOutputPort.hpp | Declares new standby video state methods in header |
| ds/include/hdmiIn.hpp | Declares new HDMI ARC port ID getter method |
| ds/hdmiIn.cpp | Implements HDMI ARC port ID retrieval function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
karuppaiyak
reviewed
Sep 9, 2025
skamath
reviewed
Sep 9, 2025
An error occurred while trying to automatically change base from
feature/RDKEMW-6120-B1
to
develop
September 9, 2025 18:08
An error occurred while trying to automatically change base from
feature/RDKEMW-6120-B1
to
develop
September 9, 2025 18:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dsSetStandbyVideoState
dsGetStandbyVideoState